[Bitbucket] Robust datetime parsing for commit dates (#1589) #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
- Coverage 42.24% 41.97% -0.28%
==========================================
Files 66 66
Lines 8588 8541 -47
Branches 1036 1041 +5
==========================================
- Hits 3628 3585 -43
- Misses 4820 4821 +1
+ Partials 140 135 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR-HARIHARAN
force-pushed
the
fix/bitbucket-datetime-1589
branch
from
a218359 to
cfbc483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a datetime parsing issue when reading Bitbucket Cloud commit
dates that include both an explicit timezone and a trailing 'Z', e.g.
Such values previously caused a ValueError when accessed via
Commit.date.Related issue: #1589
Files changed
Modified:
atlassian/bitbucket/base.pyget_time()to normalize timestamps that contain a timezonefollowed by an extraneous trailing
Z, handle Python <3.7%zcolondifferences, and attempt multiple sensible datetime formats before
falling back.
Added:
tests/test_bug_reproduction.pyCommitbuilt with"2025-09-18T21:26:38+00:00Z"returns a parsed value via.date.